Add CI for unused dependencies #3372
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latekvo
changed the title
latekvo
changed the title
m-bert
reviewed
Feb 21, 2025
Contributor
There was a problem hiding this comment.
Why is this workflow removed?
Contributor
|
I'm closing this PR since it was created before migration to monorepo structure. Also, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessary packages.
This PR reduces average yarn install time by
__%(___ms)Explanations:
--ignores="eslint-plugin-prettier"-eslint-plugin-prettieris unused, but required by the CIs.--ignores="expo-font"- Used insideapp.config.js, required by@swmansion/icons.--skip-missing- False hits. Real problematic missing packages will be caught by metro.--quiet- No output on success, simplifies creating CIs.Note: all e2e tests seem to be broken
Size differences
with these changes:
example-46,008packages at565MBroot-84,891packages at1.3GBwithout these changes (main):
example-59,275packages at689MBroot-__,___packages at1.3GBTest plan
Command for
gesture-handler/:depcheck --quiet --skip-missing --ignores="eslint-plugin-prettier"Command for
gesture-handler/example/:depcheck --quiet --ignores="eslint-plugin-prettier,expo-font"all CIs are passing
open every example app, on all platforms and architectures available for given example app
prettier still works as intended